Fix update of min/max attributes when only the hours/minutes/seconds have changed#398
Open
roland-vachter wants to merge 1 commit intoh2qutc:masterfrom
Open
Fix update of min/max attributes when only the hours/minutes/seconds have changed#398roland-vachter wants to merge 1 commit intoh2qutc:masterfrom
roland-vachter wants to merge 1 commit intoh2qutc:masterfrom
Conversation
Author
|
I would need this fix ASAP as part of a patch release for version 16. Thanks! Let me know please if I can be of any help. |
Author
|
Can someone please have a look at this? Maybe @h2qutc? |
roland-vachter
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The update of min/max values does not consider the change of hours, minutes or seconds. This is wrong, because even when min or max is updated but the date is the same only the time changes, these attributes are ignored and the validation is wrong.